Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep branch for last zig release e.g. 0.13 #200

Open
Selveris opened this issue Sep 23, 2024 · 4 comments
Open

Keep branch for last zig release e.g. 0.13 #200

Selveris opened this issue Sep 23, 2024 · 4 comments

Comments

@Selveris
Copy link

Selveris commented Sep 23, 2024

As the title say I would find it nice if there was a branch/tag with a working version for the last zig release e.g. at the moment v0.13
This would allow newcomers like me who don't use nightly build of zig to easily get started

I am specifying working because I downloaded this repo based on commit 'fac81ec499cfd64da7b846de27f6db4a0d4943bf' and the enum 'Library' is private but we need it public to init sdl

Maybe it would have worked fine with a previous commit but this show that having a dedicated branch would help

And btw thanks for providing this wrapper, zig error handling is much nicer than c ;)

@bibo38
Copy link

bibo38 commented Sep 24, 2024

I also would appreciate always supporting the latest zig stable version. Especially as the stable version is a good basis to work with multiple libraries.

I've just forked this project and rebased it to split the 0.14 commits into a separate branch (zig-master) on top of the zig-0.13.0 branch. I would suggest the following approach for this repository:

  • All functional commits go against the latest stable branch (e.g. zig-0.13.0)
  • The zig-master gets only the commits necessary to support the latest zig master version
  • For each update in the latest stable branch, a merge commit is added to zig-master to merge these changes (to avoid always creating x new commits with a rebase)
  • If a new stable zig version is released, rebase the zig-master branch to drop all the merge commits and create a corresponding new branch (e.g. zig-0.14.0 or zig-0.13.1)

@ikskuh
Copy link
Owner

ikskuh commented Sep 24, 2024

I would appreciate some help on the repo. I don't have much personal time nowadays and i'd be happy if more active users would take care of SDL.zig!

I still have some nice use cases for this library and i often use it to link against SDL, but i don't use the wrapper anymore

If one of you wants to have commit access to this repo i'd be happy to help. I would transfer ownership to ziglibs before probably, so it's "official" that it's not a personal project anymore. cc @SuperAuguste

@SuperAuguste
Copy link

Hey @ikskuh, totally understandable you don't have time to maintain this. Feel free to transfer the repo (you're an owner of ziglibs so you should be able to :)).

@lpww
Copy link

lpww commented Oct 22, 2024

@bibo38 Have you successfully pulled a branch from your fork into a zig project? I'm getting an error. This is my .gitmodules:

[submodule "lib/SDL.zig"]
	path = lib/SDL.zig
	url = https://github.com/bibo38/SDL.zig
        branch = zig-0.13.0

I'm getting this error: fatal: Unable to find refs/remotes/origin/zig-0.13.0 revision in submodule path 'lib/SDL.zig'.

It works if I specify master as the branch name but not zig-master or zig-0.13.0. Any idea what the issue could be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants