Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mouse-Over to Objective Edit #5868

Open
dartajax opened this issue Dec 2, 2024 · 5 comments · May be fixed by ilios/frontend#8255
Open

Add Mouse-Over to Objective Edit #5868

dartajax opened this issue Dec 2, 2024 · 5 comments · May be fixed by ilios/frontend#8255
Assignees

Comments

@dartajax
Copy link
Member

dartajax commented Dec 2, 2024

image

It would be nice to have the same thing when a user mouses over the above part so they know they will be editing the objective rather than expanding it.

image

@dartajax dartajax added Enhancement Needs Team Discussion For organizing issues that core team will discuss in person labels Dec 2, 2024
@dartajax
Copy link
Member Author

dartajax commented Dec 2, 2024

The reason I entered this ticket is because there is a fine line between edit and expand depending on where your mouse is pointed. It would be nice to know which will occur upon clicking. I do understand that with the text the default behavior is edit rather than expand but now that we will have both, can we add this? TEAM DISCUSSION tag added in case this is deemed not to be necessary or desired.

@dartajax
Copy link
Member Author

dartajax commented Dec 2, 2024

related to ilios/frontend#8215 in that this assumes that or a similar PR have already been merged - this could be deemed not necessary if it gets fixed in that PR.

@michaelchadwick
Copy link
Contributor

Sounds good to me, @dartajax, but I'll add it in a later PR if we agree on adding it. It would add an aria-label and title to all editable fields, since they're all going through the FadeText filter now, and not sure we want that.

@michaelchadwick michaelchadwick self-assigned this Dec 3, 2024
@jrjohnson jrjohnson removed the Needs Team Discussion For organizing issues that core team will discuss in person label Dec 5, 2024
@jrjohnson
Copy link
Member

jrjohnson commented Dec 5, 2024

Team Discussion:
@michaelchadwick is going to put a quick PR together with just this change so we can check how it behaves. We can remove the existing aria-label and replace with a title and see how it looks.

@michaelchadwick
Copy link
Contributor

PR here: ilios/frontend#8255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants