Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Linter Checks #6

Open
ayushr2 opened this issue Mar 25, 2019 · 2 comments
Open

Improve Linter Checks #6

ayushr2 opened this issue Mar 25, 2019 · 2 comments

Comments

@ayushr2
Copy link
Collaborator

ayushr2 commented Mar 25, 2019

Following up from illinois-cs241/broadway-api#58, some warnings like shadowing variable names, type mismatch warning slip by flake8. We should be able to catch such things and not let them slip into production code.

Maybe change the linter? But have been unsuccessful in finding linters which can do this.

@nmagerko
Copy link
Collaborator

Shadowing variable names should actually be caught by flake8. What you're referencing is using something like the variable name id which covers up the id builtin (which I think most linters probably don't care about, even though they probably should).

@zhengyao-lin zhengyao-lin transferred this issue from illinois-cs241/broadway-api Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants