Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Right click does not work or crashes VS code 1.96 (macOS) #178

Closed
1 task done
FNERNST opened this issue Dec 12, 2024 · 20 comments
Closed
1 task done

[Bug]: Right click does not work or crashes VS code 1.96 (macOS) #178

FNERNST opened this issue Dec 12, 2024 · 20 comments
Labels
bug Something isn't working

Comments

@FNERNST
Copy link

FNERNST commented Dec 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In the current version of VS code 1.96, a right click either crashes VS code or does not open any menus.

Expected Behavior

VS code should not crash and the corresponding menus should be opened

Steps To Reproduce

  1. Open VSCode
  2. Right click anywhere

Environment

- OS: macOS 15.1.1
- VSCode: 1.96.0
- Extension: 1.1.41
- Theme: Dark+

Anything else?

No response

Update

A bug report for VSCode has been created to update the Electron version, if this issue is affecting you then please go to that issue and give it a 👍 reaction: microsoft/vscode#236772

The fix has been merged and is set to release in a VSCode update in January 2025

Edited by @illixion

@FNERNST FNERNST added bug Something isn't working triage Cause of the issue needs to be triaged labels Dec 12, 2024
@illixion
Copy link
Owner

Can confirm, issue appears to be macOS-only, managed to capture this exception using Debugtron:

[1212/171542.178855:WARNING:in_range_cast.h(38)] value -634136515 out of range
[1212/171542.201000:WARNING:crash_report_exception_handler.cc(235)] UniversalExceptionRaise: (os/kern) failure (5)
[1212/171542.202326:ERROR:directory_reader_posix.cc(43)] opendir /Users/ixion/Library/Application Support/Code/Crashpad/attachments/61d6b144-a084-46f9-8b48-5c5c7908db36: No such file or directory (2)
[53063:1212/171542.212404:ERROR:ssl_client_socket_impl.cc(882)] handshake failed; returned -1, SSL error code 1, net_error -3

I'll block installation on macOS VSCode 1.96.x for now.

@AdiStar350
Copy link

please update on fix

@illixion illixion pinned this issue Dec 12, 2024
@illixion illixion changed the title [Bug]: Right click does not work or crashes VS code 1.96 [Bug]: Right click does not work or crashes VS code 1.96 (macOS) Dec 12, 2024
@lex-art
Copy link

lex-art commented Dec 13, 2024

I have the same bug in MaOS!

@SSPR0
Copy link

SSPR0 commented Dec 14, 2024

I got an error, too MaOS! 1.96.0

@illixion
Copy link
Owner

illixion commented Dec 14, 2024

Everyone on macOS with VSCode 1.96.0 and newer is currently experiencing this issue, no need to +1 unless you have something to add to the discussion.

Recommended solution for now is to downgrade to 1.95.3 and disable auto-updates: https://update.code.visualstudio.com/1.95.3/darwin-universal/stable

@MuhdHanish
Copy link

I've temporarily downgraded to 1.95.3 as recommended, and it's working fine. when can we expect a stable release that safely addresses the problem so we can upgrade to the latest version?

@AdiStar350
Copy link

version vs code 1.96.1,
the whole extension wont work:

Enable vibrancy command resulted in an error:
unsupported

Vibrancy does not work with VSCode 1.96.x on macOS, see here for more info.

@illixion
Copy link
Owner

@AdiStar350 please do not +1 unless you have something to add, I ask for this so that people can subscribe to this issue and stay up-to-date without unnecessary noise. This is a community-led project, and while I try to make fixes where I can, I have limited time to work on the more complex issues such as this one. Pull requests are most welcome if you'd like to see this fixed sooner.

@illixion
Copy link
Owner

Update, I've discovered that this is an Electron bug that appears to be specific to Electron 32.2.6, we'll have to wait until VSCode updates their Electron version as the window.setVibrancy function we rely on is what's affected: electron/electron#44940

This is currently the version being used in latest stable VSCode and VSCode Insiders. It is also possible to create a custom VSCode build with updated Electron, though it'll be the OSS edition of VSCode, so I'm not sure if that's something that people would be interested in. Either way, I'll update the blocking code to check the Electron version instead, so as soon as VSCode updates it, Vibrancy will start working again.

@illixion
Copy link
Owner

illixion commented Dec 21, 2024

I've created a bug report for VSCode to update the Electron version, if this issue is affecting you then please follow this link and give the issue a 👍 reaction: microsoft/vscode#236772

Edit: the fix is set to release in January 2025

@anistark
Copy link

Any alternate extension that everyone is using?

illixion added a commit that referenced this issue Dec 23, 2024
@MrVanosh
Copy link

MrVanosh commented Jan 3, 2025

Any updates for this? 🥺

@behindthepixels
Copy link

Same question! Will this fix both MacOS and Windows?

@illixion
Copy link
Owner

illixion commented Jan 6, 2025

Windows is not affected by this issue, fix is scheduled to be released in a VSCode update by the end of January, you can track progress here: microsoft/vscode#236772

@illixion illixion removed the triage Cause of the issue needs to be triaged label Jan 6, 2025
@illixion
Copy link
Owner

Small update, VSCode Insiders v1.97 has already updated Electron to 32.2.7 and I can confirm that the extension works there without any issues. As soon as it's released to the public, Vibrancy will start working again in mainline VSCode.

@GaviHunch
Copy link

is it fixed ?

@illixion
Copy link
Owner

illixion commented Feb 3, 2025

According to Microsoft's next release info, VSCode 1.97 is planned to release on 5th of February: microsoft/vscode#238813

@illixion
Copy link
Owner

illixion commented Feb 7, 2025

VSCode 1.97 is released, no issues with Vibrancy observed, everyone affected by this can go ahead and re-enable auto-updates 🎉

@illixion illixion closed this as completed Feb 7, 2025
@illixion illixion unpinned this issue Feb 8, 2025
@mateattilabarna
Copy link

@illixion

I updated to VSCode 1.97, right click still doesn't work.

@illixion
Copy link
Owner

I updated to VSCode 1.97, right click still doesn't work.

Does the problem still occur if you turn off all extensions via the triple dot menu in Extensions sidebar? Also, please go to About VSCode and copy-paste the full version info here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests