Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap.js: update to HTTPS, add Java-8 update site #86

Closed
wants to merge 1 commit into from

Conversation

frauzufall
Copy link
Member

@frauzufall frauzufall commented May 17, 2020

This PR updates the bootstrap.js script to HTTPS and adds the Java-8 update site since the HTTPS related updater JARs are also there.

I tested it by running the Fiji's build.sh script (without the deployment part) after replacing the link to this bootstrapJ8.js script with the one from this PR, checking for no errors during the execution and then I started the Linux64 version which indeed used HTTPS links by default.

I guess this script got manually copied to https://downloads.imagej.net/bootstrapJ8.js or is there another source for the bootstrapJ8.js script?

@ctrueden mentioned here that we might break someone's Java 6 installation - I'm not sure how since the bootstrapJ8.js script already created Fiji's with Java-8 enabled. Is this bootstrap.js script in this repository used for anything else?

@ctrueden ctrueden requested a review from hinerm June 5, 2020 21:11
@turekg
Copy link

turekg commented Jun 26, 2020

I've diff'd this new version with the bootstrapJ8.js script which is being used by the the fiji build script. After I changed http -> https in the latter there is a pertinent difference still. bootstrapJ8.js is till using https://update.imagej.net/jars instead of https://sites.imagej.net/Java-8/jars/. I would recommend that the fiji build.sh script be updated to always reference the bootstrap script in this repo (master branch). In the long run bootstrapJ8.js could be done away with. We should merge this ASAP

@frauzufall
Copy link
Member Author

Closing this because, if I remember correctly, we are not using the bootstrap.js script for building Fiji any more. Can we maybe just delete the script @ctrueden?

@frauzufall frauzufall closed this Oct 7, 2020
@ctrueden ctrueden deleted the bootstrap-https branch October 7, 2020 16:53
ctrueden added a commit that referenced this pull request Oct 7, 2020
@ctrueden
Copy link
Member

ctrueden commented Oct 7, 2020

I cannot find any uses of bootstrap.js or bootstrapJ8.js across the codebase, so I removed the script from this repository. However, I'll leave bootstrapJ8.js on downloads.imagej.net, just in case anyone is still making use of it. Officially unsupported now, though! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants