-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimension renaming support to to_dataset()
method
#304
Comments
To be clear: in the case of |
to_dataset()
methodto_dataset()
method
@ctrueden Great point on being clear about what we mean here! You are correct in that we are doing no reordering here, but instead we are renaming dimensions while preserving the array shape and the associated axis coordinates. I better defined the renaming behavior in this commit (73f4c35) were I added a missing docstring parameter for I recreated the same behavior, more or less, for Once I have this ready, I'll create a PR for it. It'd be nice to include this in |
This issue has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/39 |
This issue has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/48 |
We can do better here and detect what the input image is and take the appropriate steps to re-order the dataset. If you try to re-order an imglib2 image with
to_dataset(img, dim_order=['X', 'Y', 'Channel'])
only the first two dimensions will be appropriately assigned. All other dimensions are discarded andunknown
is assigned as the dimension label.The text was updated successfully, but these errors were encountered: