Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to PID_v2 to adjust the output while in Manual mode #5

Open
KissGe83 opened this issue Apr 14, 2022 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@KissGe83
Copy link

Dear All,

First of all, thank you very much for this PID V2 Library!
I have an issue with the PID SetMode function. Whatever I set, the output is still in control, the process overwrites my manual inputs.
This is perfectly working for me in PID V1, but once I replaced the library with V2 it stops to work.

I used the following methods to activate / deactivate the process, neither was working for me:
SERVOPID.SetMode(MANUAL);
SERVOPID.SetMode(PID::Manual);

I checked and it should be fine.

I called the
SERVOValue = SERVOPID.Run(PITSensorValue);
after I manually adjust the SERVOValue, the PID V1 did not do anything with the value, but V2 is adjusting.

Many thanks and Kindest Regards,
Gergely

@imax9000
Copy link
Owner

I'm guessing that it was just returning the previously calculated value, instead of the one you wrote into SERVOValue manually.

I think it's possible to make this a bit less confusing.

@imax9000 imax9000 changed the title Manual - Automatic SetMode Add a method to PID_v2 to adjust the output while in Manual mode Apr 25, 2024
@imax9000 imax9000 added the enhancement New feature or request label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants