Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morphology framework TODOs. #3

Open
3 tasks
tinevez opened this issue Mar 6, 2015 · 0 comments
Open
3 tasks

Morphology framework TODOs. #3

tinevez opened this issue Mar 6, 2015 · 0 comments
Assignees

Comments

@tinevez
Copy link
Contributor

tinevez commented Mar 6, 2015

After the merge of PR #2, the following tasks were noted to be done:

  • RectangleShape and CenteredRectangleShape should be unified and support for non-symmetric neighborhood should be added. This can all be the same class with a bunch of more constructors.
  • The xxxNeighborhoodLocalizableSampler classes share a lot of code. There is potential for unification there. We could make xxxNeighborhoodFactory implementations non-static and have them contain all the parameters required to construct the neighborhoods. Then there could be only one NeighborhoodFactory and one generic typed NeighborhoodLocalizableSampler that is used everywhere.
  • The xxxShape.NeighborhoodsAccessible.randomAccess( final Interval interval ) should make an effort to compute the interval of the source that is required (i.e., output interval plus border depending on the strel bounding box) and request a source RandomAccess for that required interval. This will allow Views to make better choices of whether it can strip away extensions in transform chains. Also in some cases it is required to actually enforce the extension for extended-and-then-cropped views. See javadoc added in imglib/imglib2@3569f58 for additional explanation. (I (Tobias) would suggest to postpone this until after the previous item has been addressed because all required logic is in the RectangleNeighborhoodLocalizableSampler already.)
@tinevez tinevez self-assigned this Mar 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant