-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add depthNear and depthFar to XRDepthInformation #43
Comments
Sorry, I missed this initially - can you share a link to where you see those defined in Chromium's IDLs? I cannot seem to find it in depth-related IDLs. I checked:
|
oops. Sorry, I added those in our repo :-) |
Correlating what piotr says, I'm only seeing depthNear and depthFar defined for XrRenderState(Init), which is specced: https://immersive-web.github.io/webxr/#xrrenderstate-interface, in case you maybe had some inheritance chain somewhere. |
@bialpio @alcooper91 we need to communicate the near and far clip plane that were used for the depth texture to the session. Otherwise we can't line them up perfectly. |
/agenda add depthNear and depthFar to XRDepthInformation We need to convey the same clipping planes that were used for computation of the depth texture |
Is it just to convey the clipping planes, or is it going to also need to change our existing text around what the values are? Here is what we currently say:
If it's just to convey the clipping planes used, then I'm not too worried. Otherwise (i.e. if you actually put values into the depth buffer that represent the distance from a near plane that's different than XRView's), I think it's going to be a breaking change. |
It is just to convey the clipping planes. We want to matches the projection matrices that are used in the immersive scene with the ones that were used to calculate the depth. |
This is not resolved yet. I will publish a PR by TPAC and hopefully I can get the engineer on the line /tpac add depth near/far + a pose |
I noticed that the IDL for XRDepthInformation in Chromium has
depthNear
anddepthFar
but they are not defined in the spec. @bialpio, should we document those?OpenXR depth sensing also exposes them so it seems they're needed.
/agenda add depthNear and depthFar to XRDepthInformation
The text was updated successfully, but these errors were encountered: