Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM tests and gate on new failures #463

Open
1 of 4 tasks
fw-immunant opened this issue Oct 31, 2024 · 2 comments
Open
1 of 4 tasks

Fix ARM tests and gate on new failures #463

fw-immunant opened this issue Oct 31, 2024 · 2 comments
Assignees

Comments

@fw-immunant
Copy link
Contributor

fw-immunant commented Oct 31, 2024

Currently (322e9db), the following tests fail on ARM:

We should fix these and make sure that future compartment violations show up as CI failures, possibly by altering our QEMU patch to only continue past the first violation if we opt in.

@fw-immunant fw-immunant self-assigned this Oct 31, 2024
@ayrtonm
Copy link
Contributor

ayrtonm commented Oct 31, 2024

This is probably the issue with simple1 #314 (comment)

@fw-immunant
Copy link
Contributor Author

fw-immunant commented Nov 4, 2024

The read_config issue boils down to us allocating untagged memory in shared_malloc which should be accessible from any compartment, but the memory accesses within the implementation of shared_malloc (in PA itself) are still applying the x18 tag. We might be able to save/restore x18 around the implementation of our shared allocation APIs, but I think we would need per-compartment copies of every shared allocation entrypoint so that the compartment to return to gets encoded in control flow.

I'm also not sure what to do about regular accesses to shared allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants