Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --output-prefix optional (or remove it entirely) #482

Open
randomPoison opened this issue Dec 13, 2024 · 2 comments
Open

Make --output-prefix optional (or remove it entirely) #482

randomPoison opened this issue Dec 13, 2024 · 2 comments
Labels
ergonomics Would make the compartmentalization API more user-friendly. rewriter

Comments

@randomPoison
Copy link
Contributor

Currently the --output-prefix flag on the rewriter is required to be specified. I'm not sure why we need that prefix to be specified by the user, it seems like we could use a default prefix of ia2_ or wrapper_ (or something similar). If there's a reason why we need to give the user an option to control that prefix, then I think we should make --output-prefix optional, though I think the better solution would be to remove it entirely if that wouldn't cause any problems.

@randomPoison randomPoison added ergonomics Would make the compartmentalization API more user-friendly. rewriter labels Dec 13, 2024
@kkysen
Copy link
Contributor

kkysen commented Dec 13, 2024

I agree. Having this option doesn't seem very useful, and it also makes referring to these files in documentation, etc. more confusing. It should also go in --output-directory (I forgot if it already does, since I just pass an absolute path).

@randomPoison
Copy link
Contributor Author

It currently puts those files in whatever directory you run the rewriter in. I agree they should go in the output directory, but when I brought that up the other day I think @ayrtonm said that doesn't make sense for some reason (I don't remember what exactly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ergonomics Would make the compartmentalization API more user-friendly. rewriter
Projects
None yet
Development

No branches or pull requests

2 participants