Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.80.0 build issue #1109

Closed
chenrui333 opened this issue Aug 1, 2024 · 2 comments · Fixed by #1115
Closed

rust 1.80.0 build issue #1109

chenrui333 opened this issue Aug 1, 2024 · 2 comments · Fixed by #1115
Assignees

Comments

@chenrui333
Copy link

at least time crate needs to be updated to 0.3.36

see time-rs/time#693

@theoparis
Copy link

#1098

@kornelski
Copy link

Caused by rust-lang/rust#127343

@kkysen kkysen self-assigned this Aug 27, 2024
kkysen added a commit that referenced this issue Aug 28, 2024
…e` dependency to build on 1.80.0 (#1115)

* Fixes #1109.

Our old nightly (1.65) pins `time-macros` to an old version, which
requires `time` to stay on an old version. But since 1.80 broke `time`
(due to time-rs/time#693 and
rust-lang/rust#127343), we need to update
`time`. Doing this requires `time-macros` to be upgraded, which requires
at least rust 1.67. There's an old PR, #811, for this, but it needs
rebasing. So for now, removing `git-testament` and its `time` dependency
is simpler, and we can add it back later once we update to a newer
nightly.

With this fix, both `cargo build -p c2rust` (the pinned nightly) and
`cargo +stable build -p c2rust` (1.80.1) now work.

If this is good, and once we merge this, we'll release a new version
with the fix.
dgherzka pushed a commit to dgherzka/c2rust that referenced this issue Sep 4, 2024
…e` dependency to build on 1.80.0 (immunant#1115)

* Fixes immunant#1109.

Our old nightly (1.65) pins `time-macros` to an old version, which
requires `time` to stay on an old version. But since 1.80 broke `time`
(due to time-rs/time#693 and
rust-lang/rust#127343), we need to update
`time`. Doing this requires `time-macros` to be upgraded, which requires
at least rust 1.67. There's an old PR, immunant#811, for this, but it needs
rebasing. So for now, removing `git-testament` and its `time` dependency
is simpler, and we can add it back later once we update to a newer
nightly.

With this fix, both `cargo build -p c2rust` (the pinned nightly) and
`cargo +stable build -p c2rust` (1.80.1) now work.

If this is good, and once we merge this, we'll release a new version
with the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants