Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change types in XML_ParserStruct #2

Open
26 of 68 tasks
rinon opened this issue Jan 14, 2020 · 2 comments
Open
26 of 68 tasks

Change types in XML_ParserStruct #2

rinon opened this issue Jan 14, 2020 · 2 comments

Comments

@rinon
Copy link
Contributor

rinon commented Jan 14, 2020

We'll start by planning out changes here, then incrementally make those changes through the codebase.

Raw pointer fields that need replacing:

  • pub m_userData: *mut c_void
  • pub m_handlerArg: *mut c_void
  • pub m_buffer: *mut c_char
  • pub m_mem: crate::expat_h::XML_Memory_Handling_Suite
  • pub m_bufferPtr: *const c_char
  • pub m_bufferEnd: *mut c_char
  • pub m_bufferLim: *const c_char
  • pub m_parseEndPtr: *const c_char
  • pub m_dataBuf: *mut crate::expat_external_h::XML_Char
  • pub m_dataBufEnd: *mut crate::expat_external_h::XML_Char
  • pub m_startElementHandler: crate::expat_h::XML_StartElementHandler
  • pub m_endElementHandler: crate::expat_h::XML_EndElementHandler
  • pub m_characterDataHandler: crate::expat_h::XML_CharacterDataHandler
  • pub m_processingInstructionHandler: crate::expat_h::XML_ProcessingInstructionHandler
  • pub m_commentHandler: crate::expat_h::XML_CommentHandler
  • pub m_startCdataSectionHandler: crate::expat_h::XML_StartCdataSectionHandler
  • pub m_endCdataSectionHandler: crate::expat_h::XML_EndCdataSectionHandler
  • pub m_defaultHandler: crate::expat_h::XML_DefaultHandler
  • pub m_startDoctypeDeclHandler: crate::expat_h::XML_StartDoctypeDeclHandler
  • pub m_endDoctypeDeclHandler: crate::expat_h::XML_EndDoctypeDeclHandler
  • pub m_unparsedEntityDeclHandler: crate::expat_h::XML_UnparsedEntityDeclHandler
  • pub m_notationDeclHandler: crate::expat_h::XML_NotationDeclHandler
  • pub m_startNamespaceDeclHandler: crate::expat_h::XML_StartNamespaceDeclHandler
  • pub m_endNamespaceDeclHandler: crate::expat_h::XML_EndNamespaceDeclHandler
  • pub m_notStandaloneHandler: crate::expat_h::XML_NotStandaloneHandler
  • pub m_externalEntityRefHandler: crate::expat_h::XML_ExternalEntityRefHandler
  • pub m_externalEntityRefHandlerArg: crate::expat_h::XML_Parser
  • pub m_skippedEntityHandler: crate::expat_h::XML_SkippedEntityHandler
  • pub m_unknownEncodingHandler: crate::expat_h::XML_UnknownEncodingHandler
  • pub m_elementDeclHandler: crate::expat_h::XML_ElementDeclHandler
  • pub m_attlistDeclHandler: crate::expat_h::XML_AttlistDeclHandler
  • pub m_entityDeclHandler: crate::expat_h::XML_EntityDeclHandler
  • pub m_xmlDeclHandler: crate::expat_h::XML_XmlDeclHandler
  • pub m_encoding: *const crate::src::lib::xmltok::ENCODING
  • pub m_initEncoding: crate::src::lib::xmltok::INIT_ENCODING
  • pub m_internalEncoding: *const crate::src::lib::xmltok::ENCODING
  • pub m_protocolEncodingName: *const crate::expat_external_h::XML_Char
  • pub m_unknownEncodingMem: *mut c_void
  • pub m_unknownEncodingData: *mut c_void
  • pub m_unknownEncodingHandlerData: *mut c_void
  • pub m_unknownEncodingRelease: Option<unsafe extern "C" fn(_: *mut c_void) -> ()>
  • pub m_processor: Option<Processor>
  • pub m_eventPtr: *const c_char
  • pub m_eventEndPtr: *const c_char
  • pub m_positionPtr: *const c_char
  • pub m_openInternalEntities: *mut OPEN_INTERNAL_ENTITY
  • pub m_freeInternalEntities: *mut OPEN_INTERNAL_ENTITY
  • pub m_declEntity: *mut ENTITY
  • pub m_doctypeName: *const crate::expat_external_h::XML_Char
  • pub m_doctypeSysid: *const crate::expat_external_h::XML_Char
  • pub m_doctypePubid: *const crate::expat_external_h::XML_Char
  • pub m_declAttributeType: *const crate::expat_external_h::XML_Char
  • pub m_declNotationName: *const crate::expat_external_h::XML_Char
  • pub m_declNotationPublicId: *const crate::expat_external_h::XML_Char
  • pub m_declElementType: *mut ELEMENT_TYPE
  • pub m_declAttributeId: *mut ATTRIBUTE_ID
  • pub m_dtd: *mut DTD
  • pub m_curBase: *const crate::expat_external_h::XML_Char
  • pub m_tagStack: *mut TAG
  • pub m_freeTagList: *mut TAG
  • pub m_inheritedBindings: *mut BINDING
  • pub m_freeBindingList: *mut BINDING
  • pub m_atts: *mut crate::src::lib::xmltok::ATTRIBUTE
  • pub m_nsAtts: *mut NS_ATT
  • pub m_tempPool: STRING_POOL
  • pub m_temp2Pool: STRING_POOL
  • pub m_groupConnector: *mut c_char
  • pub m_parentParser: crate::expat_h::XML_Parser
@rinon
Copy link
Contributor Author

rinon commented Jan 23, 2020

Handler fields were replaced in #9.

@rinon
Copy link
Contributor Author

rinon commented Jan 23, 2020

m_initEncoding, m_unknownEncodingMem, and m_internalEncoding were made safe in #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant