Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] : Adding a loading effect on all doctors page #172

Open
Jagpreet153 opened this issue May 26, 2024 · 13 comments
Open

[FEAT] : Adding a loading effect on all doctors page #172

Jagpreet153 opened this issue May 26, 2024 · 13 comments
Assignees
Labels
assigned Someone assigned to issue frontend Changes in frontend ⭐ goal: addition Addition of new feature gssoc GSSoC'24 level2 mid level fix for gssoc

Comments

@Jagpreet153
Copy link
Contributor

Jagpreet153 commented May 26, 2024

Description

Adding a preloader before loading the page matching the UI of the site

Actual Behavior

The page is blank when the site is loading

Expected Behavior

Until the site is being loaded the user will see the preloader rendering

Kindly assign this task to me under GSSoC'24

@imohit1o1
Copy link
Owner

@Jagpreet153 i need a loading on all doctors page (fetched from the db)
do u understand the issue? want to work on it?

@imohit1o1 imohit1o1 added the question Further information is requested label May 28, 2024
@imohit1o1 imohit1o1 changed the title FEAT : Preloader [FEAT] : Adding a loading effect on all doctors page May 28, 2024
@Jagpreet153
Copy link
Contributor Author

@itsmohit097 Only on all doctors page not on other pages? Sure , I want to work on this issue .

@imohit1o1
Copy link
Owner

@Jagpreet153 assigned to u. Yes only use [loader ,setLoader] on docotrs page
Only make changes regarding to the issue (no other changes need to made)
[Important] :
Do not waste your precious time. Kindly do the fork and branch process properly (read contribution.md file)
If not followed properly PR will not be merged and the issue will be assigned to another contributor.

@imohit1o1 imohit1o1 added ⭐ goal: addition Addition of new feature frontend Changes in frontend assigned Someone assigned to issue gssoc GSSoC'24 level2 mid level fix for gssoc and removed question Further information is requested labels May 29, 2024
@nishant0708
Copy link

Can i work on this issue

@imohit1o1
Copy link
Owner

@Jagpreet153 update??

@Jagpreet153
Copy link
Contributor Author

@Jagpreet153 update??

@itsmohit097 I will generate PR by today or tomorrow

@imohit1o1
Copy link
Owner

@Jagpreet153 i added a Skelton loading effect by fetching the repo u can see the changes
If u can improve it do the changes in that

@Jagpreet153
Copy link
Contributor Author

Ok @itsmohit097 Kindly add me as assignee to this issue

@Jagpreet153
Copy link
Contributor Author

@itsmohit097 Have a look . I have added another animation in the skeleton loading file . If you find it well let me know I will raise PR .

Untitled10.mp4

@imohit1o1
Copy link
Owner

@Jagpreet153 not this animation. add a shimmer effect to it.

@Jagpreet153
Copy link
Contributor Author

Jagpreet153 commented Jun 3, 2024

@itsmohit097 I have added shimmer effect , but I have not fetched doctors data from backend . So I displayed a message instead .

Untitled13.mp4

@imohit1o1
Copy link
Owner

Fine raise PR now

@Jagpreet153
Copy link
Contributor Author

@itsmohit097 please respond to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Someone assigned to issue frontend Changes in frontend ⭐ goal: addition Addition of new feature gssoc GSSoC'24 level2 mid level fix for gssoc
Projects
None yet
Development

No branches or pull requests

3 participants