Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mashups): Make sure to exclude the post_types in drafts from the mashups #271

Open
kevinwhoffman opened this issue Aug 22, 2018 · 0 comments

Comments

@kevinwhoffman
Copy link
Contributor

@marutim commented on Tue Jun 19 2018

User Story

As a user, I would like only published posts to be displayed in the mashups. Currently, it displays the posts in drafts as well.

Current Behavior

The mashup does not excludes the posts in drafts.

Possible Solution

Make sure only the post status published is considered while creating mashups.

Steps to reproduce

  • Create a mashup.
  • Then change the status of one of the post to draft and check the mashup again.
  • You will still see the post in the mashup.
  • I have even tried deleting the transients to make sure the code is refreshed.

Visuals

image
image

Related

Related HS ticket: https://secure.helpscout.net/conversation/597787591/19963/?folderId=1434552

Environment

### Begin System Info ###

-- Site Info

Site URL: http://maps-builder-plugin.local
Home URL: http://maps-builder-plugin.local
Multisite: No

-- Hosting Provider

Host: DBH: localhost, SRV: maps-builder-plugin.local

-- User Browser

Platform: Apple
Browser Name: Chrome
Browser Version: 67.0.3396.87
User Agent String: Mozilla/5.0 (Macintosh; Intel Ma
c OS X 10_12_6) AppleWebKit/537.
36 (KHTML, like Gecko) Chrome/67
.0.3396.87 Safari/537.36

-- WordPress Configuration

Version: 4.9.6
Language: en_US
Permalink Structure: /%postname%/
Active Theme: Twenty Seventeen 1.6
Show On Front: posts
Remote Post: wp_remote_post() works
Table Prefix: Length: 3 Status: Acceptable
Admin AJAX: Inaccessible
WP_DEBUG: Disabled
Memory Limit: 40M
Registered Post Stati: publish, future, draft, pending, private, trash, auto-draft, inherit, request-pending, request-confirmed, request-failed, request-completed

-- Maps Builder Configuration

Version: 2.1.2
Upgraded From: 2.1.2

-- Must-Use Plugins

-- WordPress Active Plugins

Maps Builder Pro: 2.1.2
Transients Manager: 1.7.4

-- WordPress Inactive Plugins

Duplicate Post: 3.2.2
Maps Builder: 2.1.2
WordPress phpinfo(): 16.3

-- Webserver Configuration

PHP Version: 7.1.7
MySQL Version: 5.6.37
Webserver Info: nginx/1.10.1

-- PHP Configuration

Safe Mode: Disabled
Memory Limit: 256M
Upload Max Size: 300M
Post Max Size: 1000M
Upload Max Filesize: 300M
Time Limit: 1200
Max Input Vars: 4000
Display Errors: On (1)

-- PHP Extensions

cURL: Supported
fsockopen: Supported
SOAP Client: Installed
Suhosin: Not Installed

End System Info


@marutim commented on Thu Jun 21 2018

The user followed up to check if at least, we can share some workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants