-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto active substep #814
Comments
I like 3 as it is analogous to Lines 484 to 488 in 78c954a
|
Substeps can only be actived one by one. For example, for a step with 3 substeps, it should have only the follow states:
I can't image what should happen while user press the space if just substep 3 is actived. Should only substep 1 actived? or substep 1 and 3 is actived? |
I've always preferred CSS class when possible. This way you can also use CSS directly against this class. |
Hmm... I'm only now paying more attention to what you are trying to do... It should be possible to do what you want already with just CSS: Just add |
When we enter the slide the second time, the class will be removed. So I think we have to introduce new class. Maybe I should commit a PR to be discussed. |
Ah, hmm... Good point... Even so, rather than adding a new css class, I would still want to discuss whether existing commands could be used to achieve what you want. I can actually think of 2 alternatives:
What do you think? I actually like the second option. |
I think it's useful to let use active a substep after enter the step, so the first substep (or specified substep) is active at first, then can be hidden after. e.g. we can show a slogan at first, then replacing it with actually content.
I thought of some way:
data-substep-active
/data-substep-active=<substep-idx>
tostep
elementdata-substep-active
to asubstep
elementsubstep-auto-active
to asubstep
elementThe text was updated successfully, but these errors were encountered: