-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace built-in Magento downloader with improper/mage2me #11
Comments
@azmeehan - I've refactored the Magento downloader to a stand-alone service. I'd love it if you could preview it and give me feedback: |
Some nice features:
|
@tylerssn Ive had some time to test this. Seems to work with the latest stable release tags like 2.3.5 or 2.3.4 but not with any of the branches. Ive tested with interactive and standalone Magento downloads but I keep getting the following error: Could not parse version constraint 2.4.0: Invalid version string "2.4.0-develop" Ive tried 2.3 and 2.4-develop both with the same result. |
@azmeehan - this was corrected in mage2me v1.1.0. I'm not quite sure what changed between testing and now, but you were right - installing dev branches broke down. Now, in order to install a dev branch I'm going to leave this ticket open in hopes of integrating mage2me into this template once it has been battle tested. |
Is your feature request related to a problem? Please describe.
Yes, the Lando template shouldn't have to know how to fetch Magento, only run it.
Describe the solution you'd like
Install mage2me and allow that service to be responsible for understanding Magento 2 download requirements
Describe alternatives you've considered
Have you seen this repo? Gross.
Additional context
https://github.com/improper/mage2me
From my comment in the thread:
composer create-project
.The text was updated successfully, but these errors were encountered: