Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: when deleting a folder that contains a file we can't delete, we get an uninformative message #11

Open
imsnif opened this issue Jun 17, 2020 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@imsnif
Copy link
Owner

imsnif commented Jun 17, 2020

To reproduce:

  1. Create folder /path_to_my/folder
  2. Create nested_folder /path_to_my/folder/nested_folder
  3. Create a file inside nested_folder /path_to_my_folder/folder/nested_folder/file.txt
  4. Change the permissions of nested_folder to be read only.
  5. Start diskonaut and give it /path_to_my as its path (diskonaut /path_to_my).
  6. Try to delete folder.
  7. See that we get an uninformative error message and are unsure what happened.

In this scenario, the message should read something like "Permission denied deleting /path_to_my/folder/nested_folder".

@imsnif imsnif added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 17, 2020
@u5surf
Copy link

u5surf commented Jun 18, 2020

@imsnif

Try to delete folder.

Is this deleting folder path_to_my or nested_folder?
I prefer the message that you can figure out which folder can’t you delete.Although, current implementation is not able to delete the folder and its nested folders one by one recursively. Thus it difficult to indicate which is not permitted folder

@imsnif
Copy link
Owner Author

imsnif commented Jun 19, 2020

I agree @u5surf. We'll have to implement a recursive delete of our own and catch these errors in order to do this. I would also definitely like to have the error showing the folder that failed and not its parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants