Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalization #127

Open
iamonuwa opened this issue Oct 28, 2018 · 3 comments
Open

Internalization #127

iamonuwa opened this issue Oct 28, 2018 · 3 comments
Assignees
@ralyodio @TheNaturator
Labels
enhancement New feature or request
Milestone
v1.1.0

Comments

@iamonuwa
Copy link
Collaborator

iamonuwa commented Oct 28, 2018 •
edited
Loading

Is your feature request related to a problem? Please describe.

As a user, I would love to see the app in my language

Describe the solution you'd like

Abstract texts from the code and replace with internalization template.
Describe alternatives you've considered

Additional context

See CONTRIBUTING.md for contribution guidelines
@iamonuwa iamonuwa added this to the v1.1.0 milestone Oct 28, 2018
@ralyodio ralyodio added the enhancement New feature or request label Oct 28, 2018
@ralyodio
Copy link
Contributor

We need to first move all english text in the code to the i18n/en.json file using $t('myKey') to translate inside the templates and controllers with this.$t('myKey').

@ralyodio ralyodio added the good first issue Good for newcomers label Oct 28, 2018
@iamonuwa
Copy link
Collaborator Author

Right!

@ralyodio ralyodio removed the good first issue Good for newcomers label Oct 29, 2018
@ralyodio ralyodio self-assigned this Oct 29, 2018
@TheNaturator TheNaturator self-assigned this Nov 30, 2018
@TheNaturator
Copy link
Collaborator

Right now I will change all english texts to en.json

TheNaturator added a commit to TheNaturator/imusify-web that referenced this issue Dec 1, 2018
@TheNaturator
move texts to en.json file
461fdfc 
Fixes: imusify#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ralyodio ralyodio

@TheNaturator TheNaturator

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@ralyodio @iamonuwa @TheNaturator