Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add further tests for sublayout verification #22

Open
adityasaky opened this issue Feb 20, 2019 · 0 comments
Open

Add further tests for sublayout verification #22

adityasaky opened this issue Feb 20, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adityasaky
Copy link
Member

adityasaky commented Feb 20, 2019 •
edited
Loading

Please fill in the fields below to submit an issue or feature request. The
more information that is provided, the better.

Description of issue or feature request:

#19 added sublayout verification functionality to the go implementation. However, there are certain tests missing that must be added. Specifically we must test for:

  • multi level sublayouts
  • failure to verify superlayout because of failure of verification of sublayout
  • further tests designed for verification to fail to ensure failure occurs gracefully

Current behavior:

The above tests are currently missing, as to add them, we will have to include a variety of layout and link files.

Expected behavior:

The tests must be added after the go implementation has an updated runlib capable of signing and generating layouts on the fly. We can use this capability to create the metadata files required for the tests.
@lukpueh lukpueh mentioned this issue Feb 20, 2019
Merged
@shibumi shibumi added the enhancement New feature or request label Jan 15, 2021
@adityasaky adityasaky added the good first issue Good for newcomers label May 19, 2021
sudo-bmitch pushed a commit to sudo-bmitch/in-toto-golang that referenced this issue Jul 7, 2021
@mikhailswift
Add ability to constrain functionary certs based upon cert attributes (…
346a2d0 
…in-toto#22)

* Adds CertificateConstraint struct with helper functions that can
  constrain a functionary by their provided certificate's CommonName and
  URIs.
* Adds an array of CertificateConstraints to the Step struct.
* Check constraints during verification
* Updates test files to account for layout and step changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shibumi @adityasaky