Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-based coordinate viewability should change when project type changes #295

Open
2 tasks
kueda opened this issue Jan 19, 2022 · 0 comments
Open
2 tasks
Labels

Comments

@kueda
Copy link
Member

kueda commented Jan 19, 2022

Currently when you join a traditional project, you can

  1. Allow project curators to view your hidden coordinates based on who added the observation to the project using the curator_coordinate_access preference on ProjectUser, and/or
  2. Allow project curators to view your hidden coordinates based on an observation-by-observation basis using the curator_coordinate_access on ProjectObservation

When a project changes from a traditional project to a collection or umbrella, the ProjectUser and ProjectObservation records persist (though the latter probably shouldn't) and we are still revealing coordinates based on the ProjectObservation preference. So

  • Stop revealing coordinates based on the ProjectObservation preference if the project is not traditional
  • Check whether this is happening for the ProjectUser preference and stop that too

Basically the same as inaturalist/inaturalist#3367, but we duplicate that functionality in this app too.

@kueda kueda added the bugs label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant