Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fixes for map view in Android #2549

Conversation

joergmlpts
Copy link
Contributor

@joergmlpts joergmlpts commented Dec 13, 2024

  • From ObsDetails the map is called with an observation and neither a region nor a mathod to update the region are provided. Zooming works fine as long as we keep at least one finger on the screen. When the last finger is removed, the map reverts to the initial map computed for the observation.
    A region called defaultInitialRegion is computed from the observation for the map view. This region is not updated after zooming. This does not seem to be a problem in iOS, but in Android the map is re-rendered after each gesture and it then reverts to the one computed from the observation.
    This fix introduces a state observationRegion for defaultInitialRegion that is updated after each gesture.
  • The fix for the Current Location button consists in explicitly invoking a callback after animateToRegion() is called.

Closes #2529
Closes #2555

@joergmlpts joergmlpts changed the title introduce state for defaultInitialRegion; fix for issue #2529 fix: introduce state for defaultInitialRegion & support Current Location button in Android Dec 16, 2024
@joergmlpts joergmlpts changed the title fix: introduce state for defaultInitialRegion & support Current Location button in Android fix: bug fixes for map view in Android Dec 16, 2024
@joergmlpts joergmlpts closed this Dec 26, 2024
@joergmlpts joergmlpts deleted the 2529-zoom-level-resets-on-every-zoom-in-obsdetails-map-on-android branch December 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant