Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change center crop to be only 88 percent of available width/height #7

Open
jtklein opened this issue Nov 10, 2023 · 2 comments
Open
Labels

Comments

@jtklein
Copy link
Contributor

jtklein commented Nov 10, 2023

The center crop yields better vision scores if the overall size of the center square is reduced to be that of 88% of the original frame of an uncropped range. So, if the original frame is 1000x2000 pixel the center square should be the center 880x880 pixel.

@jtklein
Copy link
Contributor Author

jtklein commented Mar 1, 2024

This #22 introduces a param to set the crop ratio as an option. Works on Android only though at the moment.

@jtklein jtklein added the ios label Mar 1, 2024
@jtklein
Copy link
Contributor Author

jtklein commented Mar 1, 2024

On iOS the best way forward is probably to use https://github.com/mrousavy/vision-camera-resize-plugin in vision-camera v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant