Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPV6 options draft - AD evaluation comments #248

Open
shwethab opened this issue May 2, 2022 · 1 comment
Open

IPV6 options draft - AD evaluation comments #248

shwethab opened this issue May 2, 2022 · 1 comment
Assignees

Comments

@shwethab
Copy link
Collaborator

shwethab commented May 2, 2022

Martin Duke [email protected]
Apr 29, 2022, 10:23 AM (3 days ago)
to draft-ietf-ippm-ioam-ipv6-options.all

Thanks for a concise document!

My main concern was the clarity of Section 4. I was not clear on what this was specifying due to these problems:

  • "Deployments select one of these extension header types depending on how IOAM is used, as described in section 4 of [I-D.ietf-ippm-ioam-data]"

That draft certainly doesn't say anything about extension header types. Guidance about which header type to use is actually later in Section 4 of this document!

  • "IOAM Type: 8-bit field as defined in section 7.2 in [I-D.ietf-ippm-ioam-data]."

Sec 7.2 does not define this at all.

  • I do not understand the presentation format of the five bullets after "In-situ OAM Option-Types are inserted as Option data as follows:", The previous text defines "option types" and "IOAM types" but each of these bullets provides an "IOAM Option Type". Which does this correspond to? Please don't introduce a new and confusing term here! After skimming through ioam-data, I think the "Option Type" is the bit field listed in this draft, and the "IOAM type" field is taken from the registry in Sec 8.1 of ioam-data. Is that correct? If so, it is very confusingly described.

  • After several re-readings, I think there are actually only two Option Types that map to the five IOAM types. Perhaps, instead of using 'xxxxx' for all unassigned bits, you can use 'xxxxx' and 'yyyyy' to make the overlaps among these option types more clear?

NITS:


(4) s/lenght/length

(5.1) I'm not sure what you mean by "the source that inserts and leaks the IOAM data". It both inserts and leaks it?

(5.4.1) please expand ION on first use.
@shwethab shwethab self-assigned this May 2, 2022
@shwethab
Copy link
Collaborator Author

possible table to map data option type to v6 header - and options

shwethab added a commit that referenced this issue Jun 16, 2022
shwethab added a commit that referenced this issue Jun 16, 2022
shwethab added a commit that referenced this issue Jun 16, 2022
shwethab added a commit that referenced this issue Jun 16, 2022
shwethab added a commit that referenced this issue Jun 17, 2022
shwethab added a commit that referenced this issue Jun 17, 2022
* #248 AD evaluation comments

* #248 AD evaluation comments

* #248 AD evaluation comments

* #248 AD evaluation comments

Co-authored-by: shwetha.bhandari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant