forked from andygrunwald/go-jira
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream changes #2
Open
lawrencejones
wants to merge
185
commits into
master
Choose a base branch
from
lawrence-merge-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+15,338
−3,414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nwald#451) * GitHub Actions: Upgrade staticcheck action version to v1.2.0 * GitHub Actions: Fix go-version of setup-go * Set version golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f See google/go-jsonnet#596 and felder/go-jsonnet@7949745
closes andygrunwald#441 Co-authored-by: Luciano da Silva Ribas <lucribas@users>
It was a nice idea, and I still like it, but I don't see a big benefit of this anymore.
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…runwald#453) Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.7 to 0.5.8. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](google/go-cmp@v0.5.7...v0.5.8) --- updated-dependencies: - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ndygrunwald#464) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* README: Add chapter "State of this library" Related andygrunwald#474 * README: Add chapter "Supported Go versions" Related andygrunwald#290 * Go: Raise supported version to v1.18 Related andygrunwald#290 * Fix "package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)" * go fmt
…documentation" (andygrunwald#492) * README: Add chapter "State of this library" Related andygrunwald#474 * README: Add chapter "Supported Go versions" Related andygrunwald#290 * Go: Raise supported version to v1.18 Related andygrunwald#290 * README: Add chapter "Supported Jira versions" and "Official Jira API documentation" Related: andygrunwald#295 * Fix "package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)" * go fmt
* Splitting Jira client into OnPremise and Cloud Both products look like the same, but the API differs. We split those into their own packages to make it explicit. Splitting was done by * copying the files * renaming the packages * fixing the path to mock-test-data * Fix test filenames for PermissionSchemeService * Remove legacy request with context function The function `http.NewRequestWithContext` has been added in Go 1.13. Before the release 1.13, to use Context we need create `http.Request` then use the method `WithContext` to create a new `http.Request` with Context from the existing `http.Request`. Doc: https://golang.org/doc/go1.13#net/http We don't support Go 1.13 anymore. That is why we can drop this function * Authentication transport: Split into own files * cloud/onpremise: Add basic READMEs * onpremise: fix import of onpremise package * CHANGELOG: Add chapter about how to migrate to v2 (with split clients)
…proof and configurable (andygrunwald#509) * Moved all Sub-Services to a common service struct * NewClient: Change order of arguments, baseUrl first, http client second * Client: Add default user agent to identify the client * addOptions: Rename opt to opts, because those can be multiple * Delete NewRawRequestWithContext, because NewRawRequest requires now a context Every time we make a request, we should deal with the context. We aim to avoid requests without any context. That is why we make this the new default * Add Client() method to get the HTTP client * Add Changelog entries and Migration entries * Delete NewRequestWithContext, because NewRequest requires now a context * Migrate Client changes from Cloud to OnPremise * Moved all Sub-Services to a common service struct * NewClient: Change order of arguments, baseUrl first, http client second * Client: Add default user agent to identify the client * addOptions: Rename opt to opts, because those can be multiple * Delete NewRawRequestWithContext, because NewRawRequest requires now a context * Add Client() method to get the HTTP client * Add Changelog entries and Migration entries * Delete NewRequestWithContext, because NewRequest requires now a context
…` requires `context` Fix andygrunwald#506
…uest` requires `context` Fix andygrunwald#506
…runwald#505) Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.8 to 0.5.9. - [Release notes](https://github.com/google/go-cmp/releases) - [Commits](google/go-cmp@v0.5.8...v0.5.9) --- updated-dependencies: - dependency-name: github.com/google/go-cmp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ald#494) * GitHub Actions: Split testing workflow into several jobs Related andygrunwald#484 * GitHub issues: Remove reference to github.com/go-jira/jira Initially we received a few bug tickets related to github.com/go-jira/jira. Hence we set up a config.yml to point users toward this project. We did not receive them for a while. Thats why we are removing this reference. * GitHub Actions: Rename "test and lint" to "unit tests"
Kudos goes to @stxphcodes for his work in andygrunwald#469
Onpremise/Auth: Update README and examples for Bearer Auth
Thanks goes to @wardviaene for his work in andygrunwald#455
Cloud/Board: Add Location to Board struct
Thanks goes to @Avarei for his work in andygrunwald#463
Cloud/Board: Add Sprint goal
…countId Additionally: * Cloud/Group: Renamed `Group.Add` to `Group.AddUserByGroupName` * Cloud/Group: Renamed `Group.Remove` to `Group.RemoveUserByGroupName` Thanks a lot to @t-junjie for the work in andygrunwald#414
Cloud/Group: Update Add/Remove and replace username parameter with accountId
…transition {Cloud/On premise}/Issue: add missing comments about closing Response.Body
var testIssueID was not declared but was being used across the example.
fix(code-snippet): example jira ticket status update
Bumps [dominikh/staticcheck-action](https://github.com/dominikh/staticcheck-action) from 1.2.0 to 1.3.0. - [Release notes](https://github.com/dominikh/staticcheck-action/releases) - [Changelog](https://github.com/dominikh/staticcheck-action/blob/master/CHANGES.md) - [Commits](dominikh/staticcheck-action@v1.2.0...v1.3.0) --- updated-dependencies: - dependency-name: dominikh/staticcheck-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
corrected the signature of jira.NewClient() in the PAT example. first comes the httpClient jira.httpClient and second comes the baseURL string
Update README.md
Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.2 to 4.5.0. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.4.2...v4.5.0) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.0.0-20210220032956-6a3ed077a48d to 0.6.0. - [Release notes](https://github.com/golang/term/releases) - [Commits](https://github.com/golang/term/commits/v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…odules/golang.org/x/term-0.6.0 chore(deps): bump golang.org/x/term from 0.0.0-20210220032956-6a3ed077a48d to 0.6.0
…odules/github.com/golang-jwt/jwt/v4-4.5.0 chore(deps): bump github.com/golang-jwt/jwt/v4 from 4.4.2 to 4.5.0
…ub_actions/dominikh/staticcheck-action-1.3.0 chore(deps): bump dominikh/staticcheck-action from 1.2.0 to 1.3.0
github-actions
bot
added
documentation
Improvements or additions to documentation
jira-onpremise
jira-cloud
labels
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring us up-to-date with upstream.