From aba0a2694ea683ebb58de725c59bc663cd934b2c Mon Sep 17 00:00:00 2001 From: Ned Zimmerman <ned@bight.dev> Date: Tue, 9 Jul 2024 15:43:29 -0300 Subject: [PATCH 1/5] fix: add lint script --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 24c2b4d..95827aa 100644 --- a/package.json +++ b/package.json @@ -10,6 +10,7 @@ "clean": "rimraf _site", "debug": "DEBUG=Eleventy* eleventy", "dev": "cross-env NODE_ENV=development eleventy --serve", + "lint": "run-s -l lint:*", "lint:scripts": "biome check .", "lint:markdown": "markdownlint-cli2 \"**/*.md\"", "start": "npm-run-all -l clean dev", From 8a30de7aa7b06d6d74a9569b3355767b5163ad55 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman <ned@bight.dev> Date: Tue, 9 Jul 2024 15:45:40 -0300 Subject: [PATCH 2/5] fix: resolve linting issues, add markdownlint config --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 8d37329..5b8d1e0 100644 --- a/README.md +++ b/README.md @@ -1,2 +1,3 @@ # standards.idrc.ocadu.ca + Website for IDRC standards development work. From 4763509c5407f8a24e53e8c5263b378e4ba43932 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman <ned@bight.dev> Date: Tue, 9 Jul 2024 15:45:55 -0300 Subject: [PATCH 3/5] fix: add markdownlint config --- .markdownlint-cli2.cjs | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .markdownlint-cli2.cjs diff --git a/.markdownlint-cli2.cjs b/.markdownlint-cli2.cjs new file mode 100644 index 0000000..12c86aa --- /dev/null +++ b/.markdownlint-cli2.cjs @@ -0,0 +1,4 @@ +module.exports = { + config: require("./node_modules/markdownlint-config-fluid/.markdownlintrc.json"), + ignores: ["node_modules", "src/collections", "CHANGELOG.md"] +}; From 1b025f70ae702a5c0ca391bbe9fe67ece6b1edc6 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman <ned@bight.dev> Date: Tue, 9 Jul 2024 15:49:26 -0300 Subject: [PATCH 4/5] fix: remove test command --- .github/workflows/lint-and-test.yml | 44 ++++++++++++++--------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml index 7eee5e3..29f8380 100644 --- a/.github/workflows/lint-and-test.yml +++ b/.github/workflows/lint-and-test.yml @@ -21,25 +21,25 @@ jobs: run: | npm ci npm run lint - npm run test - - name: Save code coverage to artifact - uses: actions/upload-artifact@v4 - with: - name: code-coverage - path: "coverage/clover.xml" - retention-days: 5 - upload-coverage: - name: Upload code coverage - runs-on: ubuntu-latest - needs: - - lint-test - steps: - - name: Fetch code coverage artifact - uses: actions/download-artifact@v4 - with: - name: code-coverage - - name: Upload coverage to Codecov - uses: codecov/codecov-action@v4 - with: - token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: true + # npm run test + # - name: Save code coverage to artifact + # uses: actions/upload-artifact@v4 + # with: + # name: code-coverage + # path: "coverage/clover.xml" + # retention-days: 5 + # upload-coverage: + # name: Upload code coverage + # runs-on: ubuntu-latest + # needs: + # - lint-test + # steps: + # - name: Fetch code coverage artifact + # uses: actions/download-artifact@v4 + # with: + # name: code-coverage + # - name: Upload coverage to Codecov + # uses: codecov/codecov-action@v4 + # with: + # token: ${{ secrets.CODECOV_TOKEN }} + # fail_ci_if_error: true From 33cec3735b146aa69dd785242c0c5afd1962d328 Mon Sep 17 00:00:00 2001 From: Ned Zimmerman <ned@bight.dev> Date: Tue, 9 Jul 2024 15:49:52 -0300 Subject: [PATCH 5/5] ci: set up Node --- .github/workflows/lint-and-test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint-and-test.yml b/.github/workflows/lint-and-test.yml index 29f8380..4b360be 100644 --- a/.github/workflows/lint-and-test.yml +++ b/.github/workflows/lint-and-test.yml @@ -12,6 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 - name: Cache node modules uses: actions/cache@v4 with: