Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when updating to Django 4 #193

Open
mijaramillo opened this issue Jan 11, 2022 · 1 comment
Open

Issue when updating to Django 4 #193

mijaramillo opened this issue Jan 11, 2022 · 1 comment

Comments

@mijaramillo
Copy link

mijaramillo commented Jan 11, 2022

image

Hello, when I upgraded my project to django 4 and tried to run it with runserver I got the error attached. Therefore, the dependency requires the smart_text function which is no longer available for this version of Django. However, in the Django repository it is noted that smart_text is deprecated, so smart_str should be used, which is available in Django 4, so this could solve the problem.

simevo pushed a commit to simevo/django-wkhtmltopdf that referenced this issue Jan 20, 2022
simevo pushed a commit to simevo/django-wkhtmltopdf that referenced this issue Jan 20, 2022
@simevo
Copy link

simevo commented Jan 20, 2022

AFAICT the tentative fix works.

As we wait for it to land here, you can get it by patching your requirements.txt like this:

-django-wkhtmltopdf
+git+https://github.com/simevo/django-wkhtmltopdf.git@bugfix/issue-193-smart_text

I am not sure about making a PR because this may break with older Djangos ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants