You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was setting up a new WeatherFlow Tempest device to show up in HomeKit, and it was always showing up as 32 degrees Fahrenheit in the Home app even though the outdoor temp is below 32 degrees F. The device is set to Fahrenheit, so I'd checked the Temperate value is Fahrenheit box in the HomeKit-Bridge configuration. I was able to track down the root cause of it showing as 32 degrees F (0 degrees C) to line 1632 in homekit.py, where the temperature conversion is being done:
# Do temperature conversion on the value
if attribute in ["CurrentTemperature", "TargetTemperature", "HeatingThresholdTemperature", "CoolingThresholdTemperature"]:
if self.convertFahrenheit:
try:
cvalue = float(obj.value)
cvalue = (cvalue - 32) / 1.8000
if cvalue < 0: cvalue = 0 # <-- This is the offending line
obj.value = cvalue
except:
pass # Nothing happened, leave the current value
I was able to get it working by commenting out line 1632. Is overriding all temps below 32 degrees F the intended behavior or is it a bug? Is there an edge case I'm not considering or some other behavior I'm not aware of that commenting out that line will impact?
If it's a bug, I'll open a PR to fix it. Thanks!
The text was updated successfully, but these errors were encountered:
I was setting up a new WeatherFlow Tempest device to show up in HomeKit, and it was always showing up as 32 degrees Fahrenheit in the Home app even though the outdoor temp is below 32 degrees F. The device is set to Fahrenheit, so I'd checked the
Temperate value is Fahrenheit
box in the HomeKit-Bridge configuration. I was able to track down the root cause of it showing as 32 degrees F (0 degrees C) to line 1632 inhomekit.py
, where the temperature conversion is being done:I was able to get it working by commenting out line 1632. Is overriding all temps below 32 degrees F the intended behavior or is it a bug? Is there an edge case I'm not considering or some other behavior I'm not aware of that commenting out that line will impact?
If it's a bug, I'll open a PR to fix it. Thanks!
The text was updated successfully, but these errors were encountered: