Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reductions returning array containers #177

Open
thomasgibson opened this issue Oct 20, 2021 · 1 comment
Open

Reductions returning array containers #177

thomasgibson opened this issue Oct 20, 2021 · 1 comment
Labels
design decisions Anything related to overhauling or redesigning code question Further information is requested

Comments

@thomasgibson
Copy link
Collaborator

Mention by @majosm here: #154 (comment).

Based on a slack discussion, here is a proposal: nodal_{min, max, sum} and norm should return array containers (by computing reductions on each component of the underlying array container. We probably also want to have a flat_norm routine.
@thomasgibson thomasgibson added question Further information is requested design decisions Anything related to overhauling or redesigning code labels Oct 20, 2021
@thomasgibson thomasgibson mentioned this issue Oct 20, 2021
Merged
@inducer
Copy link
Owner

inducer commented Jan 13, 2022

I'm OK with having that as an option, though I think "reduce everything down to a scalar" as default behavior is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design decisions Anything related to overhauling or redesigning code question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inducer @thomasgibson