limit sphinx version

[matthiasdiener]

No description provided.

[inducer]

Is this to address the doc example failure seen by @majosm in #316? Is there a sphinx issue that might explain this?

[matthiasdiener]

Is this to address the doc example failure seen by @majosm in #316? Is there a sphinx issue that might explain this?

Yes, this fixes the doc build at least locally for me (sphinx 7.2.4 is fine, 7.2.5 breaks). There is no issue I could find, but sphinx-doc/sphinx#11645 is the underlying PR that causes the failure.

[inducer]

Left a comment.

[alexfikl]

Unrelated, but why does the documentation take over 1h to generate (almost as much as pylint!)? Is it just that hello-grudge.py example?

[matthiasdiener]

Unrelated, but why does the documentation take over 1h to generate (almost as much as pylint!)? Is it just that hello-grudge.py example?

Just the conda env create takes more than 1 hour for docs and pylint (see e.g. here). I suspect that using mamba env create would significantly speed this up (at least that's what we saw in mirgecom). Env creation takes more time for these two tests since they pull in matplotlib, which in turn pulls in many more packages.

[alexfikl]

Just the conda env create takes more than 1 hour for docs and pylint (see e.g. here). I suspect that using mamba env create would significantly speed this up (at least that's what we saw in mirgecom). Env creation takes more time for these two tests since they pull in matplotlib, which in turn pulls in many more packages.

Never thought of looking at that, but yeah, you're completely right! Wow!
Not super familiar with the conda/mamba split, but ci-support.sh seems to download Mambaforge. Does that not mean it uses mamba under the hood?
https://github.com/inducer/ci-support/blob/756aec4768a505b715e3da9ca66d6e72c4f55dfb/ci-support.sh#L116

[matthiasdiener]

Not super familiar with the conda/mamba split, but ci-support.sh seems to download Mambaforge. Does that not mean it uses mamba under the hood? https://github.com/inducer/ci-support/blob/756aec4768a505b715e3da9ca66d6e72c4f55dfb/ci-support.sh#L116

Installing Mambaforge AFAIK only means that mamba as a command is available by default, conda is still available as a separate command. Currently, ci-support still uses conda for env creation: https://github.com/inducer/ci-support/blob/756aec4768a505b715e3da9ca66d6e72c4f55dfb/ci-support.sh#L255

For some strange reason I'm unable to create a fork on gitlab.tiker.net, so I can't send a PR currently.

Edit: Created a PR here: inducer/ci-support#26

[inducer]

Thanks!

[matthiasdiener]

Unrelated, but why does the documentation take over 1h to generate (almost as much as pylint!)? Is it just that hello-grudge.py example?

With inducer/ci-support#27, the documentation build went from 73 min to <5 min 👀

[alexfikl]

With inducer/ci-support#27, the documentation build went from 73 min to <5 min 👀

Much more environmentally friendly! Thanks for figuring this out! ❤️