Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firedrake CI should include parallel tests #891

Open
connorjward opened this issue Nov 29, 2024 · 0 comments
Open

Firedrake CI should include parallel tests #891

connorjward opened this issue Nov 29, 2024 · 0 comments

Comments

@connorjward
Copy link
Contributor

By not having parallel tests loopy missed an issue regarding mismatching hashes between ranks. I think if you had parallel tests then this would not have happened.

I think this could be fixed simply be modifying the line

pytest --tb=native -rsxw --durations=10 -m 'not parallel' tests/multigrid/

by removing the -m "not parallel" bit.

Note that we also usually have a different set of "smoke tests" instead of tests/multigrid: https://www.firedrakeproject.org/download.html#testing-the-installation

Further, tests/multigrid has just been moved to tests/firedrake/multigrid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@connorjward