Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access Race Checker: account for non-zero hardware axes lower bounds #816

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Access Race Checker: account for non-zero hardware axes lower bounds #816

merged 3 commits into from
Jan 26, 2024

Conversation

kaushikcfd
Copy link
Collaborator

Closes #600.

@kaushikcfd kaushikcfd mentioned this pull request Nov 5, 2023
Closed
inducer
inducer reviewed Nov 5, 2023
View reviewed changes
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Some griping below, as usual, but (hopefully) quite fixable.

loopy/schedule/tools.py Outdated Show resolved Hide resolved
loopy/schedule/tools.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Jan 26, 2024

LGTM, thanks!

@inducer inducer merged commit 268a7f4 into inducer:main Jan 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer Awaiting requested review from inducer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tighter write race checking has broken test_argmax in test_scan
2 participants
@kaushikcfd @inducer