-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace pyrsistent.PMap, immutables.Map, immutabledict with constantdict #884
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ba71046
replace pyrsistent.PMap, immutables.Map with immutabledict
matthiasdiener b9cf0ea
Merge branch 'main' into constantdict2
matthiasdiener b45f92a
Merge branch 'main' into constantdict2
matthiasdiener 9698278
Merge branch 'main' into constantdict2
matthiasdiener 6dadbe7
go back to immutables.Map for Tree
matthiasdiener 91c14a1
ruff fixes
matthiasdiener 9f1132b
spelling
matthiasdiener af46922
Merge branch 'main' into constantdict2
matthiasdiener 1845e94
switch to constantdict
matthiasdiener c69207e
Merge branch 'main' into constantdict2
matthiasdiener c8edca7
lint fixes
matthiasdiener ad486b0
doc fix
matthiasdiener c5e499d
work around doc failure
matthiasdiener 7b0d862
remove some spurious changes
matthiasdiener ba93a2f
clean up types a bit
matthiasdiener e06e31a
simplify with_kernel
matthiasdiener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether this is the intended behavior here (or whether
arg_id_to_dtype
should just be set toNone
). This bug seems to have come in with 70cc100#diff-c2536267212ab595d8fbafdc40257bf749f171cc1e23c6c5113fcf2e41546b02 (seems like typing with immutabledict is not strict enough so that mypy did not catch this earlier)Same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can just be
assert arg_id_to_dtype is not None
(sinceNone
is hashable, we should not end up in this branch).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in ba93a2f