Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_order to FunctionSpace #50

Open
inducer opened this issue Jan 13, 2022 · 2 comments
Open

Add with_order to FunctionSpace #50

inducer opened this issue Jan 13, 2022 · 2 comments

Comments

@inducer
Copy link
Owner

inducer commented Jan 13, 2022

Inspired by this comment https://github.com/inducer/meshmode/pull/291/files#r777549852 from @alexfikl

If when/done: use it in the spots in the PR that provided the inspiration.

@inducer
Copy link
Owner Author

inducer commented Jan 13, 2022

Problem: It probably shouldn't be in FunctionSpace, since order isn't necessarily a well-defined concept for every function space (e.g. anisotropic-order tensor product).

@alexfikl
Copy link
Collaborator

Hm, yeah, forgot about that. Maybe something narrower then? At least for the use cases in meshmode

  • mp.space_for_shape(shape, 1): just needs something to interpolate to vertices.
  • mp.space_for_shape(shape, 2) in tesselation: seems to mostly be used as a way to bisect the element. This will probably fail if we try to use PN on a square anyway?
  • mp.space_for_shape(shape, order) in visualization: VTK only supports isotropic things anyway, at least for now.

Not sure, probably better to wait until things start breaking 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants