New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searches n + ... + 3 + 2 + 1 times #12

Open

coolaj86 opened this issue Feb 7, 2015 · 1 comment

Contributor

coolaj86 commented Feb 7, 2015

You loop through your queue here:
https://github.com/indutny/node-nat-upnp/blob/master/lib/nat-upnp/ssdp.js#L109

And then you loop through the sockets inside of that loop before popping one off, here:
https://github.com/indutny/node-nat-upnp/blob/master/lib/nat-upnp/ssdp.js#L69

It looks like a bug, but it doesn't seem to break anything. Haven't dug deep enough to pull request, just making a note.

coolaj86 mentioned this issue

A few fixes #13

Closed

Contributor Author

coolaj86 commented Feb 11, 2015

It was a result of incorrect logic. (>= instead of <).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment