forked from facebookarchive/pfff
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathmain_spatch.ml
463 lines (380 loc) · 13.8 KB
/
main_spatch.ml
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
(*
* The author disclaims copyright to this source code. In place of
* a legal notice, here is a blessing:
*
* May you do good and not evil.
* May you find forgiveness for yourself and forgive others.
* May you share freely, never taking more than you give.
*)
open Common
open Ast_php
module Ast = Ast_php
module V = Visitor_php
module Ast2 = Ast_js
module V2 = Visitor_js
module PI = Parse_info
open Parse_info
(*****************************************************************************)
(* Purpose *)
(*****************************************************************************)
(*
* A syntactical patch for PHP. https://github.com/facebook/pfff/wiki/Spatch
*
* opti: git grep xxx | xargs spatch_php ...
*
*
* Alternatives:
* - you could also just write a sgrep that put a special mark to the
* place where it matched and then do the transformation using an
* emacs macro leveraging those marks.
*)
(*****************************************************************************)
(* Flags *)
(*****************************************************************************)
let verbose = ref true
let apply_patch = ref false
let spatch_file = ref ""
(* action mode *)
let action = ref ""
(*****************************************************************************)
(* Wrappers *)
(*****************************************************************************)
let pr2 s =
if !verbose then Common.pr2 s
(*****************************************************************************)
(* Helpers *)
(*****************************************************************************)
(* Some helper functions when using the low-level transformation API of pfff.
* You should use the spatch DSL if you can.
*)
type transformation = {
(* Works by side effect on the tokens in the AST, see the transfo field.
* It returns a boolean indicating whether any transformation was done.
*)
trans_func: Ast_php.program -> bool;
(* optimisation; if a file does not contain certain keywords we don't
* even have to parse it
*)
grep_keywords: string list option;
}
let apply_transfo transfo xs =
let files = Lib_parsing_php.find_php_files_of_dir_or_files xs in
let pbs = ref [] in
(* xhp and transformation was not mixing well, but now it's better
* thanks to builtin xhp support
*)
Flag_parsing_php.show_parsing_error := false;
Flag_parsing_php.verbose_lexing := false;
let nbfiles = List.length files in
Common.execute_and_show_progress ~show_progress:true nbfiles (fun k ->
files +> List.iter (fun file ->
let file = Common.relative_to_absolute file in
pr2 (spf "processing: %s" file);
k();
let worth_trying =
match transfo.grep_keywords with
| None -> true
| Some xs -> Common.contain_any_token_with_egrep xs file
in
if not worth_trying then ()
else
try (
let (ast2) =
try
Parse_php.parse file +> fst
with Parse_php.Parse_error err ->
Common.pr2 (spf "warning: parsing problem in %s" file);
[]
in
let ast = Parse_php.program_of_program2 ast2 in
let was_modified = transfo.trans_func ast in
(* old:
* let patch = Patch.generate_patch !edition_cmds
* ~filename_in_project:file file in
* patch |> List.iter pr
*)
if was_modified then begin
let s = Unparse_php.string_of_program2_using_tokens ast2 in
let tmpfile = Common.new_temp_file "trans" ".php" in
Common.write_file ~file:tmpfile s;
let diff = Common.cmd_to_list (spf "diff -u %s %s" file tmpfile) in
diff |> List.iter pr;
if !apply_patch
then Common.write_file ~file:file s;
end
) with exn ->
Common.push2 (spf "PB with %s, exn = %s" file (Common.exn_to_s exn)) pbs;
));
!pbs +> List.iter Common.pr2
(*****************************************************************************)
(* Main action *)
(*****************************************************************************)
let main_action xs =
if Common.null_string !spatch_file
then failwith "I need a semantic patch file; use -c";
let spatch_file = !spatch_file in
(* old: let pattern = dumb_spatch_pattern in *)
let pattern = Spatch_php.parse_spatch spatch_file in
let files = Lib_parsing_php.find_php_files_of_dir_or_files xs in
files +> Common.index_list_and_total +> List.iter (fun (file, i, total) ->
pr2 (spf "processing: %s (%d/%d)" file i total);
let resopt = Spatch_php.spatch pattern file in
resopt +> Common.do_option (fun (s) ->
let tmpfile = Common.new_temp_file "trans" ".php" in
Common.write_file ~file:tmpfile s;
let diff = Common.cmd_to_list (spf "diff -u %s %s" file tmpfile) in
diff |> List.iter pr;
if !apply_patch
then Common.write_file ~file:file s;
)
)
(*****************************************************************************)
(* Extra actions *)
(*****************************************************************************)
(* -------------------------------------------------------------------------*)
(* to test *)
(* -------------------------------------------------------------------------*)
(* see also demos/simple_refactoring.ml *)
let simple_transfo xs =
let files = Lib_parsing_php.find_php_files_of_dir_or_files xs in
Flag_parsing_php.show_parsing_error := false;
Flag_parsing_php.verbose_lexing := false;
files +> List.iter (fun file ->
pr2 (spf "processing: %s" file);
let (ast2, _stat) = Parse_php.parse file in
let ast = Parse_php.program_of_program2 ast2 in
let hook = { V.default_visitor with
V.klvalue = (fun (k, _) x ->
match Ast.untype x with
| FunCallSimple((Name ("foo", info_foo)), (lp, args, rp)) ->
pr2 "found match";
let ii = Lib_parsing_php.ii_of_any (Lvalue x) in
ii |> List.iter (fun info ->
info.transfo <- Remove
);
info_foo.transfo <- Replace (AddStr "1");
()
| _ -> k x
);
}
in
(V.mk_visitor hook) (Program ast);
let s = Unparse_php.string_of_program2_using_tokens ast2 in
let tmpfile = Common.new_temp_file "trans" ".php" in
Common.write_file ~file:tmpfile s;
let diff = Common.cmd_to_list (spf "diff -u %s %s" file tmpfile) in
diff |> List.iter pr;
);
()
(* -------------------------------------------------------------------------*)
(* An example of an XHP transformation *)
(* -------------------------------------------------------------------------*)
(*
* The transformation below can be encoded via this syntactical patch:
*
* <ui:section-header
* - border=X
* ></ui:section-header>
*
* There are nevertheless currenty a few limitations in spatch which
* will cause this syntactical patch to fail to transform all the
* relevant code (e.g. because of some XHP isomorphisms not yet
* handled by spatch). In the mean time the code below uses the low-level
* transformation API of pfff to express the same transformation;
* it can be used as a reference for spatch to compare with.
*)
let remove_border_attribute ast =
let was_modified = ref false in
(* $ ./pfff -dump_php_ml tests/php/spatch/border_var.php
*
* [StmtList(
* [ExprStmt(
* (Assign((Var(DName(("a", i_1)), Ref(NoScope)), tlval_2), i_3,
* (XhpHtml(
* Xhp((["ui"; "section-header"], i_4),
* [(("href", i_5), i_6,
* XhpAttrString(i_7, [EncapsString(("foo", i_8))], i_9));
* (("border", i_10), i_11,
* XhpAttrString(i_12, [EncapsString(("1", i_13))], i_14))],
* i_15, [XhpText(("
* This is nuts
* ", i_16))],
* (Some(["ui"; "section-header"]), i_17))),
* t_18)),
* t_19), i_20)]); FinalDef(i_21)]
*)
let visitor = V.mk_visitor { V.default_visitor with
V.kxhp_html = (fun (k, _) x ->
match x with
| Xhp ( (["ui"; "section-header"], _), attributes, _, _, _)
| XhpSingleton ( (["ui"; "section-header"], _), attributes, _) ->
attributes +> List.iter (fun attr ->
match attr with
| (("border", _tok_border), _tok_equal, _xhp_attr_value) ->
was_modified := true;
let tokens = Lib_parsing_php.ii_of_any (XhpAttribute attr) in
tokens +> List.iter (fun tok ->
tok.transfo <- Remove;
);
| _ -> ()
);
(* recurse *)
k x
(* recurse *)
| _ -> k x
);
}
in
visitor (Program ast);
!was_modified
let remove_border_attribute_transfo = {
trans_func = remove_border_attribute;
grep_keywords = Some ["border"];
}
(* -------------------------------------------------------------------------*)
(* Add action attribute to <ui:form> *)
(* -------------------------------------------------------------------------*)
(*
* Here is the spatch (disjunction are currently not supported in spatch
* so have to do things manually):
*
* <ui:form
* (
* action=...
* |
* + action="#"
* )
* >
*
* todo: maybe we could generalize this transformation and add to
* spatch some command lines like:
* * -add_xhp_attribute_if_not_there "ui:form" "action='#'"
* * -remove_xhp_attribute "ui:form" "border"
* a la lex-pass. Or maybe it's better to add support in the DSL directly
* so one can write the syntactical patch above.
*)
let add_action_ui_form_transfo_func ast =
let was_modified = ref false in
let visitor = V.mk_visitor { V.default_visitor with
V.kxhp_html = (fun (k, _) xhp ->
(* mostly copy paste of: pfff -dump_php tests/.../ui_form.php *)
match xhp with
| XhpSingleton((["ui"; "form"], info_tag), attributes, _)
| Xhp ((["ui"; "form"], info_tag), attributes, _, _, _)
->
if not (attributes +>
List.exists (fun ((attr_name,_), _tok, attr_val) ->
attr_name = "action"
))
then begin
was_modified := true;
info_tag.PI.transfo <- PI.AddAfter (PI.AddStr " action=\"#\"");
end;
k xhp
| _ -> k xhp (* call the continuation *)
);
}
in
visitor (Program ast);
!was_modified
let add_action_ui_form_transfo = {
trans_func = add_action_ui_form_transfo_func;
grep_keywords = Some ["ui:form"];
}
(*---------------------------------------------------------------------------*)
(* regression testing *)
(*---------------------------------------------------------------------------*)
let test () =
let suite = Unit_matcher_php.spatch_unittest in
OUnit.run_test_tt suite |> ignore;
()
(*---------------------------------------------------------------------------*)
(* the command line flags *)
(*---------------------------------------------------------------------------*)
let spatch_extra_actions () = [
(* see also demos/simple_refactoring.ml *)
"-simple_transfo", " <files_or_dirs>",
Common.mk_action_n_arg (simple_transfo);
"-remove_border_attribute", " <files_or_dirs>",
Common.mk_action_n_arg (apply_transfo remove_border_attribute_transfo);
"-add_action_ui_form", " <files_or_dirs>",
Common.mk_action_n_arg (apply_transfo add_action_ui_form_transfo);
"-test", "",
Common.mk_action_0_arg test;
]
(*****************************************************************************)
(* The options *)
(*****************************************************************************)
let all_actions () =
spatch_extra_actions()++
[]
let options () =
[
"-f", Arg.Set_string spatch_file,
" <spatch_file>";
"-c", Arg.Set_string spatch_file,
" <spatch_file>";
"-apply_patch", Arg.Set apply_patch,
" ";
"-verbose", Arg.Set verbose,
" ";
] ++
(* Flag_parsing_php.cmdline_flags_pp () ++ *)
Common.options_of_actions action (all_actions()) ++
Common.cmdline_flags_devel () ++
Common.cmdline_flags_verbose () ++
Common.cmdline_flags_other () ++
[
"-version", Arg.Unit (fun () ->
Common.pr2 (spf "spatch_php version: %s" Config.version);
exit 0;
),
" guess what";
(* this can not be factorized in Common *)
"-date", Arg.Unit (fun () ->
Common.pr2 "version: $Date: 2010/04/25 00:44:57 $";
raise (Common.UnixExit 0)
),
" guess what";
] ++
[]
(*****************************************************************************)
(* Main entry point *)
(*****************************************************************************)
let main () =
Common_extra.set_link ();
let usage_msg =
spf "Usage: %s [options] <file or dir> \nDoc: %s\nOptions:"
(Common.basename Sys.argv.(0))
"https://github.com/facebook/pfff/wiki/Spatch"
in
(* does side effect on many global flags *)
let args = Common.parse_options (options()) usage_msg Sys.argv in
(* must be done after Arg.parse, because Common.profile is set by it *)
Common.profile_code "Main total" (fun () ->
(match args with
(* --------------------------------------------------------- *)
(* actions, useful to debug subpart *)
(* --------------------------------------------------------- *)
| xs when List.mem !action (Common.action_list (all_actions())) ->
Common.do_action !action xs (all_actions())
| _ when not (Common.null_string !action) ->
failwith ("unrecognized action or wrong params: " ^ !action)
(* --------------------------------------------------------- *)
(* main entry *)
(* --------------------------------------------------------- *)
| x::xs ->
main_action (x::xs)
(* --------------------------------------------------------- *)
(* empty entry *)
(* --------------------------------------------------------- *)
| [] ->
Common.usage usage_msg (options());
failwith "too few arguments"
)
)
(*****************************************************************************)
let _ =
Common.main_boilerplate (fun () ->
main ();
)