Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete command UML Sequence Diagram Incorrect #10

Open
inezkok opened this issue Nov 17, 2023 · 1 comment
Open

Delete command UML Sequence Diagram Incorrect #10

inezkok opened this issue Nov 17, 2023 · 1 comment
Labels
severity.Low status.Done type.DocumentationBug

Comments

@inezkok
Copy link
Owner

inezkok commented Nov 17, 2023 •
edited
Loading

The UML Sequence diagram below (found under Logic component in DG) might be wrong since it shows that a split up activation bar for the model part when it should be one continuous activation bar:

image.png
@nus-pe-script
Copy link

nus-pe-script commented Nov 20, 2023 •
edited by inezkok
Loading

Team's Response

Thank you for your input. deletePerson(1) and commitAddressBook() are different methods, hence they have different activation bars. According to the textbook, if they are different methods, they should have separate activation bars.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity.Low status.Done type.DocumentationBug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nus-pe-script @inezkok