Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 digit phone number parameter for employee is allowed #3

Open
inezkok opened this issue Nov 17, 2023 · 1 comment
Open

3 digit phone number parameter for employee is allowed #3

inezkok opened this issue Nov 17, 2023 · 1 comment

Comments

@inezkok
Copy link
Owner

inezkok commented Nov 17, 2023

I tried adding an employee with only 3 digits as the phone number 123 but it was allowed? This might not be very realistic since usually phone numbers are 8 digits long

command: add i/A1 n/John Doe p/123 e/[email protected] d/Marketing r/Manager s/5000

image.png

@nus-pe-script
Copy link

nus-pe-script commented Nov 20, 2023

Team's Response

Thank you for your input. This is an intended outcome as we believe that in companies, there might be use of work extension numbers which are typically three digits long. Hence we chose to accept three-digit numbers.

We found this on google.
image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants