Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent error message for Edit command #4

Open
inezkok opened this issue Nov 17, 2023 · 1 comment
Open

Inconsistent error message for Edit command #4

inezkok opened this issue Nov 17, 2023 · 1 comment

Comments

@inezkok
Copy link
Owner

inezkok commented Nov 17, 2023

When trying to edit command using edit 0 n/alex the following message is shown:

image.png

However, when trying using edit 100 n/alex the following message is shown:

image.png

I think that the error messages should be consistent so it's easier for the users to know that they are invalid indexes?

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023

Team's Response

Thank you for your input. We believe that this is the correct behaviour as the first error message is trying to say that the INDEX has to be a positive number while the second error message is trying to say that 100 is not a valid index as there is no employee with the index 100. We believe that this should be considered a feature flaw instead.

Under the Feature Flaw bug:

image.png

Items for the Tester to Verify

❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants