Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not specific sort success message #7

Open
inezkok opened this issue Nov 17, 2023 · 1 comment
Open

Not specific sort success message #7

inezkok opened this issue Nov 17, 2023 · 1 comment

Comments

@inezkok
Copy link
Owner

inezkok commented Nov 17, 2023

After trying to sort the list with different parameters I realised that the success message for all is the same and it might be a little confusing since you might not know which field the list was sorted by?

Success message shown below:

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023

Team's Response

Thank you for your input. We could have improved this in a further iteration, but we believe that it is currently not in scope. In addition, users can use the history command to check what they sorted the list by.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: While I agree that it should be a feature flaw, I believe that it should be Accepted instead of NotInScope. Based on the course website, for a feature flaw to be considered as not in scope, it should be of lower priority and require greater effort to implement.

image.png

However, I believe that it would require little effort to just add the field being sorted by in the error message and hence should be Accepted rather than NotInScope.


❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants