Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find command doesn't allow for multiple of the same parameter #9

Open
inezkok opened this issue Nov 17, 2023 · 1 comment
Open

Find command doesn't allow for multiple of the same parameter #9

inezkok opened this issue Nov 17, 2023 · 1 comment

Comments

@inezkok
Copy link
Owner

inezkok commented Nov 17, 2023

I tried to find employees with names containing doe or test but it doesnt work. I think that the constraint is too strict since managers might want to find two specific employees by their names:

image.png

@nus-se-bot
Copy link

nus-se-bot commented Nov 20, 2023

Team's Response

Thank you for your input. We acknowledge that HR staff members should be able to find two specific employees by their names, and in actuality, we have indeed implemented that feature in EmployeeManager. As can be seen below for our second example, we can find employees with the names Alex and David by leaving a space between the two keywords while only using one flag.

Screenshot 2023-11-19 at 7.06.29 PM.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: While I agree that it is my fault for missing out on the example given, I believe that in the case where this was not actually implemented (and was a bug), the severity level of the bug would be a Medium. If the find command only worked for one keyword for each parameter (eg only one name), then it would cause inconvenience for users. Especially in the scenario where the user is trying to search up multiple employees to maybe increment their salaries, the user would have to individually find each employee then increment their salary then repeat for the next employee.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants