Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collab #1

Open
19h opened this issue Jun 22, 2020 · 2 comments
Open

Collab #1

19h opened this issue Jun 22, 2020 · 2 comments

Comments

@19h
Copy link
Contributor

19h commented Jun 22, 2020

Hey

just wanted to let you know that I've been working on improving upon your work (https://github.com/19h/rust-swagger-codegen_v3) and I really appreciate your efforts on this.

I made the methods in the generated traits and impls async as async traits aren't stable yet I included async_trait.

I also fixed the versions in the Cargo.yaml and added a fallback package name. There was a missing 'mut' in the generated code of the methods in the impls (auth_query).

Because mustache doesn't really allow logic (i.e. comparison etc.) the string-crate thing isn't solved yet.

Regards

@inferrna
Copy link
Owner

Happy to hear my work was helpful. If it working for your purposes, maybe it's time to send it to main swagger repo? Still didn't it because it was tested with only one API

@19h
Copy link
Contributor Author

19h commented Jun 22, 2020

There are still some kinks to work out.. https://github.com/19h/polygon-rs is generated with it.

I'll create a PR against your repo. Can we collaborate in this repo? There's still that crate::models::String bug to fix. I'm sure it can land somewhere after in a PR against the main codegen repo..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants