Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow StatefulSet PriorityClass to be configured #1850

Closed
ryanemerson opened this issue Aug 11, 2023 · 2 comments
Closed

Allow StatefulSet PriorityClass to be configured #1850

ryanemerson opened this issue Aug 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ryanemerson
Copy link
Contributor

It should be possible for a user to configure the PriorityClassName used by the cluster StatefulSet via the Infinispan CR:

kind: Infinispan
...
spec: 
  statefulset: 
    affinity: 
      ...
    priorityClassName: ""
    # Possible future configurations
    tolerations: 
      ...
    topologySpreadConstraints: 
      ...

Utilising a nested spec.statefulset structure provides increased flexibility that we can leverage for future enhancements such as #1801 and #1803

@ryanemerson ryanemerson added the enhancement New feature or request label Aug 11, 2023
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Aug 11, 2023
ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Aug 11, 2023
@Crumby
Copy link
Collaborator

Crumby commented Aug 15, 2023

@ryanemerson Wouldn't it be better to go with something like qos, scheduling or schedulingRules instead of statefulset (btw. it should be statefulSet for consistency). The latter sounds way to generic as basically anything could fit in there including bunch of stuff we already have defined elsewhere and in the same time it won't allow for full SS configuration (as it shouldn't).

@ryanemerson
Copy link
Contributor Author

Very good points. I like scheduling, so it would be:

spec: 
  scheduling: 
    affinity: 
      ...
    priorityClassName: ""
    # Possible future configurations
    tolerations: 
      ...
    topologySpreadConstraints: 
      ...

ryanemerson added a commit to ryanemerson/infinispan-operator that referenced this issue Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants