Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Possible issue with the library: object.entries requires that input parameters #15

Open
obsidianart opened this issue Oct 11, 2019 · 5 comments

Comments

@obsidianart
Copy link

#ISSUE

PathObject.ts can return undefined but subscriptionsHandler.ts crash if it returns undefined
on ...Object.entries(values).map(val => ({, since entries can't be called on undefined.

if we say if (starredPath && cleanedPath && values) { the app seems to work but I'm not sure why no one else is having the issue

Logging out those vars

 LOG  cleanedPath 
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath use
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath .
 LOG  starredPath false
 LOG  pathObject [Function pathObject]
 LOG  pathObjectOutcome undefined
 LOG  cleanedPath user
 LOG  starredPath false
 LOG  pathObject [Function pathObject]

#Versions
This started happening after updating all libs, out of 2 projects with (likely) the same versions only one is crashing

    "react-navigation": "4.0.10",
    "react-navigation-redux-helpers": "4.0.1",
    "react-navigation-stack": "^1.9.3",
    "redux-persist": "6.0.0",
@obsidianart
Copy link
Author

I`ve solved this problem only by adding true to createEnhancer(), so Reactotron.createEnhancer(true) .
Up to you if you want to close this or not.

@ghost
Copy link

ghost commented Mar 28, 2020

However, by doing this, none of the state subscriptions do work after adding true to createEnchancer.

@fukhaos
Copy link

fukhaos commented Apr 1, 2020

Works using the last beta version of Reactotron

@BoKKeR
Copy link

BoKKeR commented Jun 25, 2020

I am still facing this issue after updating to "reactotron-redux": "^3.1.3". Did a full reinstallation including pod updates.

createEnhancer(true) helps but as said before the subscriptions stop working with it.

@xilin
Copy link

xilin commented Dec 17, 2021

Should be related to the version of reactotron you use

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants