You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the case you have a caching layer such as Cloudflare, the cookie esForms-country will get cached and will be set incorrectly for any subsequent user. Say for instance that the non-cached page was requested by a Hungarian user, this cookie will be set to esForms-country=HU, and then any other user, no matter where they are from, will have this cookie set.
I'm not sure if this is still being used (seeing from the code I think it is in Geolocation.php and geolocation.js), but I've also noticed the cookieless setup that was merged in #370 so I'm not sure if this is used or not.
This cookie should be set only on specific page, where it is needed, not globally.
This is further affecting things such as Varnish cache, as it will disable page caching there.
In the case you have a caching layer such as Cloudflare, the cookie
esForms-country
will get cached and will be set incorrectly for any subsequent user. Say for instance that the non-cached page was requested by a Hungarian user, this cookie will be set toesForms-country=HU
, and then any other user, no matter where they are from, will have this cookie set.I'm not sure if this is still being used (seeing from the code I think it is in
Geolocation.php
andgeolocation.js
), but I've also noticed the cookieless setup that was merged in #370 so I'm not sure if this is used or not.This cookie should be set only on specific page, where it is needed, not globally.
This is further affecting things such as Varnish cache, as it will disable page caching there.
There should be fallback cases, such that the geolocation info is pulled from the caching layer first (https://developers.cloudflare.com/fundamentals/reference/http-request-headers/#cf-ipcountry).
The text was updated successfully, but these errors were encountered: