Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Default composer.json in newly generated themes does not validate. #424

Open
goranalkovic-infinum opened this issue Sep 4, 2024 · 1 comment
Open

[BUG] Default composer.json in newly generated themes does not validate. #424

goranalkovic-infinum opened this issue Sep 4, 2024 · 1 comment
Assignees
@iruzevic
Labels
bug Something isn't working

Comments

@goranalkovic-infinum
Copy link
Contributor

goranalkovic-infinum commented Sep 4, 2024 •
edited
Loading

The private and version keys shouldn't be there, it fails config validation.

"license": "proprietary", can be added instead per-project, if needed.
@goranalkovic-infinum goranalkovic-infinum added the bug Something isn't working label Sep 4, 2024
@mbmjertan
Copy link
Collaborator

mbmjertan commented Sep 4, 2024 •
edited
Loading

I would suggest not setting any composer project metadata apart from require, require-dev, scripts and mandatory keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iruzevic iruzevic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbmjertan @iruzevic @goranalkovic-infinum