Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin reloading for development #25863

Open
pauldix opened this issue Jan 18, 2025 · 0 comments · May be fixed by #25865
Open

Add plugin reloading for development #25863

pauldix opened this issue Jan 18, 2025 · 0 comments · May be fixed by #25865
Labels

Comments

@pauldix
Copy link
Member

pauldix commented Jan 18, 2025

To make plugin development easier, we should be able to mark a plugin to get reloaded automatically from the filesystem if this is set. I think we don't want to check the filesystem on every call to a trigger to see if the modified time is changed on the file. However, if that is inexpensive to do, then we should do that. Otherwise, let's have a setting that puts a plugin in development mode, where it is reloaded from disk on every triggering of it.

@pauldix pauldix added the v3 label Jan 18, 2025
pauldix added a commit that referenced this issue Jan 18, 2025
Adds the request plugin type. Triggers can be bound to an API endpoint at /api/v3/engine/<path>. Requests will get yielded to the plugin with the query parameters, request parameters, and request body.

I didn't implement the test endpoint for this plugin type as it seems much more natural for users to save the file and make a new request. Once #25863 is done it'll make it very easy.

Closes #25862
pauldix added a commit that referenced this issue Jan 19, 2025
This updates plugins so that they will reload the code if the local file is modified. Github pugins continue to be loaded only once when they are initially created or loaded on startup.

This will make iterating on plugin development locally much easier.

Closes #25863
@pauldix pauldix linked a pull request Jan 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant