Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: framework for sys events #25602

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

praveen-influx
Copy link
Contributor

(not to merge)

Mainly PoC code,

  • uses runtime reflection to dynamically create StructArray from an arbitrary event data
  • it deviates from the original idea to allow querying select * from system.foo (where foo is the event type) and requires select * from system.events where event_type='foo' (there are ways to allow system.events.foo, but given both achieve similar result and this approach does not require changing SystemSchemaProvider, I parked it there)
  • one big disadvantage is, it uses runtime reflection using bevy_reflect, which means events cannot have certain types as they're not supported by bevy_reflect crate. This includes Arc<str> and this may (or may not) be a show stopper. Also, there's no nesting support in this PR but I think it is doable though.
  • because of runtime reflection, need to be extra careful in testing to make sure all the types are mapped correctly in arrow otherwise it results in runtime error.

closes: #25581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add framework for capturing system level events that can be queried using system tables
1 participant