Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for postinstall #827

Closed
make-github-pseudonymous-again opened this issue Mar 23, 2024 · 2 comments · Fixed by #951
Closed

Add regression test for postinstall #827

make-github-pseudonymous-again opened this issue Mar 23, 2024 · 2 comments · Fixed by #951
Labels
dx This is about developer experience

Comments

@make-github-pseudonymous-again
Copy link
Contributor

No description provided.

@make-github-pseudonymous-again make-github-pseudonymous-again added the dx This is about developer experience label Mar 23, 2024
Merged
1 task
@make-github-pseudonymous-again
Copy link
Contributor Author

Partially covered by #937. Would still be nice to have an independent smoke test that checks that the favicon and/or the fonts are present in the public folder.

@make-github-pseudonymous-again
Copy link
Contributor Author

Might make sense to move all generated assets to a dedicated subdirectory to simplify this and other automation.

make-github-pseudonymous-again added a commit that referenced this issue May 14, 2024
@make-github-pseudonymous-again
👩‍💻 dx: Smoke test NPM postinstall hook.
d8a215b 
Fixes #827.
Merged
make-github-pseudonymous-again added a commit that referenced this issue May 14, 2024
@make-github-pseudonymous-again
👩‍💻 dx: Smoke test NPM postinstall hook.
81564c2 
Fixes #827.
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
@make-github-pseudonymous-again
👩‍💻 dx: Smoke test NPM postinstall hook.
e809d16 
Fixes #827.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dx This is about developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Smoke test NPM postinstall hook infoderm/patients
1 participant
@make-github-pseudonymous-again