Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting on let-ins missing a body like val foo = 1 #1536

Open
bugarela opened this issue Oct 22, 2024 · 1 comment
Open

Improve error reporting on let-ins missing a body like val foo = 1 #1536

bugarela opened this issue Oct 22, 2024 · 1 comment
Labels
error messages Collects issues steming from poor error messages UX impacts or improves user experience

Comments

@bugarela
Copy link
Collaborator

Having this type of error on the ANTLR scope is really bad, because it is never able to provide a useful error and many times this breaks parsing of anything below the partial expression. This is a very common problem because even advanced users will write this type of partial expressions on WIP definitions, and it breaks analysis much more than it should.

The grammar should be fine in expressions like this, and then we can report a missing body in toIrListener.

@bugarela bugarela added UX impacts or improves user experience error messages Collects issues steming from poor error messages labels Oct 22, 2024
@bugarela
Copy link
Collaborator Author

perhaps the same for "an if always needs an else" errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error messages Collects issues steming from poor error messages UX impacts or improves user experience
Projects
None yet
Development

No branches or pull requests

1 participant